[true-async] Enable HTTP/3 for true-async-server (v0.7.0 + baseline-h3/static-h3)#771
Closed
EdmondDantes wants to merge 4 commits into
Closed
[true-async] Enable HTTP/3 for true-async-server (v0.7.0 + baseline-h3/static-h3)#771EdmondDantes wants to merge 4 commits into
EdmondDantes wants to merge 4 commits into
Conversation
The server gained a working HTTP/3 listener (35 phpt green, incl. E2E GET/ POST/streaming/static over QUIC). entry.php already binds the H3 UDP listener on :8443 by default; it just wasn't being benchmarked because meta.json subscribed to no h3 profile. Subscribe baseline-h3 + static-h3 so the arena actually exercises HTTP/3. A 120-iteration back-to-back restart repro (16 and 64 workers) showed 0 startup failures with the H3 listener on, so no per-profile gating is needed — h2 (TCP :8443) and h3 (QUIC UDP :8443) coexist as designed.
Pin to trueasync/php-true-async:0.7.0-rc.3-php8.6 — the first published image carrying server v0.7.0, which ships the HTTP/3 / QUIC listener (ngtcp2 1.22.1 + nghttp3 1.15.0). Pairs with subscribing baseline-h3 + static-h3 so the arena actually exercises HTTP/3. Also document the QUIC UDP port (8443/udp) in EXPOSE.
# Conflicts: # frameworks/true-async-server/Dockerfile
EdmondDantes
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
Contributor
Author
|
/benchmark -f true-async-server |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turn HTTP/3 on for true-async-server and benchmark it.
trueasync/php-true-async:0.7.0-rc.3-php8.6(wasbeta.5) —first published image carrying server v0.7.0, which ships the full HTTP/3 /
QUIC server (ngtcp2 1.22.1 + nghttp3 1.15.0).
entry.php(addHttp3Listeneron UDP :8443,default-on,
H3_DISABLE=1to opt out). It was dropped in [true-async] drop HTTP/3 listener #744.baseline-h3+static-h3inmeta.json.setTlsBufferBytes, Add Gin: Go web framework with httprouter (~80k⭐) #29) —matches the built-in default, set explicitly so the arena's TLS write buffer
stays fixed.
8443/udp) inEXPOSE.